cmd/operator-sdk: OLM integration alpha run/cleanup CLI#2402
Merged
estroz merged 5 commits intooperator-framework:masterfrom Jan 15, 2020
Merged
cmd/operator-sdk: OLM integration alpha run/cleanup CLI#2402estroz merged 5 commits intooperator-framework:masterfrom
alpha run/cleanup CLI#2402estroz merged 5 commits intooperator-framework:masterfrom
Conversation
using OLM via manifests stored in a registry-server. cmd/operator-sdk/alpha/olm: add operator up/down commands
estroz
requested review from
hasbro17,
jmccormick2001,
jmrodri,
joelanford and
theishshah
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
size/L
estroz
force-pushed
the
feature/olm-poc-cli
branch
from
69b071d to
42928e3
Compare
estroz
force-pushed
the
feature/olm-poc-cli
branch
from
42928e3 to
eb6f89a
Compare
estroz
changed the title
olm up/down CLIalpha run/cleanup CLI
joelanford
approved these changes
Jan 15, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM after a couple of nits and minor questions.
|
|
||
| ### Added | ||
|
|
||
| - Added [`run`](./doc/cli/operator-sdk_alpha_run.md) amd [`cleanup`](./doc/cli/operator-sdk_alpha_cleanup.md) subcommands (under the `alpha` subcommand) to manage deployment/deletion of operators. These commands currently interact with OLM via an in-cluster registry-server created using an operator's on-disk manifests and managed by `operator-sdk`. ([#2402](ttps://github.com/operator-framework/operator-sdk/pull/2402)) |
Member
There was a problem hiding this comment.
Suggested change
| - Added [`run`](./doc/cli/operator-sdk_alpha_run.md) amd [`cleanup`](./doc/cli/operator-sdk_alpha_cleanup.md) subcommands (under the `alpha` subcommand) to manage deployment/deletion of operators. These commands currently interact with OLM via an in-cluster registry-server created using an operator's on-disk manifests and managed by `operator-sdk`. ([#2402](ttps://github.com/operator-framework/operator-sdk/pull/2402)) | |
| - Added [`run`](./doc/cli/operator-sdk_alpha_run.md) and [`cleanup`](./doc/cli/operator-sdk_alpha_cleanup.md) subcommands (under the `alpha` subcommand) to manage deployment/deletion of operators. These commands currently interact with OLM via an in-cluster registry-server created using an operator's on-disk manifests and managed by `operator-sdk`. ([#2402](ttps://github.com/operator-framework/operator-sdk/pull/2402)) |
| ### Options | ||
|
|
||
| ``` | ||
| --force-registry Force deletion of the in-cluster registry. This option is a no-op on 'up'. |
Member
There was a problem hiding this comment.
Curious about this: This option is a no-op on 'up'.
Does up need to be run? But that would make it seem like it's always a no-op. I'm a little confused...
Member
Author
There was a problem hiding this comment.
This flag should be specific to cleanup so I've moved it to cleanup.NewCmd().
| // ManifestsDir is a directory containing a package manifest and N bundles | ||
| // of the operator's CSV and CRD's. OperatorVersion can be set to the | ||
| // version of the desired operator version's subdir and Up()/Down() will | ||
| // version of the desired operator version's subdir and Run()/Down() will |
Member
There was a problem hiding this comment.
Suggested change
| // version of the desired operator version's subdir and Run()/Down() will | |
| // version of the desired operator version's subdir and Run()/Cleanup() will |
| ``` | ||
| --force-registry Force deletion of the in-cluster registry. This option is a no-op on 'up'. | ||
| -h, --help help for run | ||
| --include strings Path to Kubernetes resource manifests, ex. Role, Subscription. These supplement or override defaults generated by up/down |
Member
There was a problem hiding this comment.
Suggested change
| --include strings Path to Kubernetes resource manifests, ex. Role, Subscription. These supplement or override defaults generated by up/down | |
| --include strings Path to Kubernetes resource manifests, ex. Role, Subscription. These supplement or override defaults generated by run/cleanup |
camilamacedo86
approved these changes
Jan 15, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
After solving the small nits added by @joelanford
It shows ok to b merged for me as well.
/lgtm
/approved
5 tasks
|
New changes are detected. LGTM label has been removed. |
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
Jan 17, 2020
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change: 'olm up/down' commands will deploy and delete an operator using OLM via manifests stored in an in-cluster registry-server managed by the SDK.
Motivation for the change:
operator-sdkshould provide tools to interact with OLM. See #1912 for past discussion of CLI.Closes #1912.