Add docs about not running e2e testing m directly#2629
Merged
estroz merged 1 commit intooperator-framework:masterfrom Mar 7, 2020
Merged
Add docs about not running e2e testing m directly#2629estroz merged 1 commit intooperator-framework:masterfrom
estroz merged 1 commit intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
estroz
suggested changes
Mar 6, 2020
| It is initialized by MainEntry and can be used anywhere in the tests. | ||
| It is initialized by the MainEntry function and can be used anywhere in the tests. As several | ||
| required arguments are initialized and added by MainEntry, do not attempt to run the testing M | ||
| directly. |
jberkhahn
force-pushed
the
e2e_main_entry
branch
2 times, most recently
from
6bd1a9e to
acad700
Compare
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
jberkhahn
force-pushed
the
e2e_main_entry
branch
from
acad700 to
24fd4bf
Compare
estroz
approved these changes
Mar 7, 2020
Member
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add docs text explaining why e2e operator tests must use the testing framework's MainEntry function.
Motivation for the change:
e2e tests that do not use the framework MainEntry function cause confusing errors when attempting to run your test, the source of which is not obvious. See #1908.
Closes #1908