commands/operator-sdk/cmd/local: add namespace flag#274
Merged
fanminshi merged 2 commits intooperator-framework:masterfrom May 23, 2018
Merged
commands/operator-sdk/cmd/local: add namespace flag#274fanminshi merged 2 commits intooperator-framework:masterfrom
fanminshi merged 2 commits intooperator-framework:masterfrom
Conversation
fanminshi
reviewed
May 22, 2018
|
|
||
| upLocalCmd.Flags().StringVar(&kubeConfig, "kubeconfig", "", "The file path to kubernetes configuration file; defaults to $HOME/.kube/config") | ||
| upLocalCmd.Flags().StringVar(&operatorFlags, "operator-flags", "", "The flags that the operator needs. Example: \"--flag1 value1 --flag2=value2\"") | ||
| upLocalCmd.Flags().StringVarP(&namespace, "namespace", "n", "default", "The namespace where the operator will watch.") |
Contributor
There was a problem hiding this comment.
I am debating whether should we add a short named flag for namespace because none of the other flags have a short version.
I'd suggest we don't add it now. Maybe we can revisit adding the short flags in a future pr.
Suggest to avoid using the word will and keep description in present tense: The namespace where the operator will watch. -> The namespace where the operator watches for changes?
Contributor
|
Could you also update the https://github.com/operator-framework/operator-sdk/blob/master/CHANGELOG.md to include this change? Just modify |
eac3646 to
b5c88e4
Compare
Contributor
Author
|
I've applied the changes please take a look. |
fanminshi
reviewed
May 22, 2018
| ### Added | ||
|
|
||
| - Added `operator-sdk up` command to help deploy an operator. Currently supports running an operator locally against an existing cluster e.g `operator-sdk up local --kubeconfig=<path-to-kubeconfig>`. See `operator-sdk up -h` for help. [#219](https://github.com/operator-framework/operator-sdk/pull/219) | ||
| - Added `operator-sdk up` command to help deploy an operator. Currently supports running an operator locally against an existing cluster e.g `operator-sdk up local --kubeconfig=<path-to-kubeconfig> --namespace=<operator-namespace>`. See `operator-sdk up -h` for help. [#219](https://github.com/operator-framework/operator-sdk/pull/219) |
Contributor
Contributor
|
lgtm after nits |
This was referenced May 23, 2018
m1kola
pushed a commit
to m1kola/operator-sdk
that referenced
this pull request
Jun 7, 2024
…istency-openshift-4.12-openshift-enterprise-operator-sdk Updating openshift-enterprise-operator-sdk images to be consistent with ART
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #273
This adds the
--namespaceflag to the up local command and the default value is the "default" namespace.Example:
operator-sdk up local --namespace operatorHelp output