Skip to content

*: apiGroup to apiVersion#28

Merged
fanminshi merged 1 commit intooperator-framework:masterfrom
fanminshi:generator_naming_refactor
Feb 21, 2018
Merged

*: apiGroup to apiVersion#28
fanminshi merged 1 commit intooperator-framework:masterfrom
fanminshi:generator_naming_refactor

Conversation

@fanminshi
Copy link
Copy Markdown
Contributor

fixes #27

@fanminshi
Copy link
Copy Markdown
Contributor Author

cc/ @hasbro17 @hongchaodeng

@hongchaodeng
Copy link
Copy Markdown
Contributor

LGTM

@hongchaodeng
Copy link
Copy Markdown
Contributor

defer to @hasbro17

Comment thread pkg/generator/generator.go Outdated
type Generator struct {
apiGroup string
kind string
// apiVersion is the kubernete apiVersion that has the format of $GROUP_NAME/$VERSION.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*kubernetes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@hasbro17
Copy link
Copy Markdown
Contributor

LGTM

@fanminshi fanminshi merged commit f382703 into operator-framework:master Feb 21, 2018
m1kola pushed a commit to m1kola/operator-sdk that referenced this pull request Jun 7, 2024
ci/test/scaffolding: fix hybrid operator dependency resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discuss: difference between apiVersion and apiGroup

3 participants