Controller fails on empty manifest files from a Helm Chart.#2831
Merged
bharathi-tenneti merged 4 commits intooperator-framework:masterfrom Apr 13, 2020
Merged
Controller fails on empty manifest files from a Helm Chart.#2831bharathi-tenneti merged 4 commits intooperator-framework:masterfrom
bharathi-tenneti merged 4 commits intooperator-framework:masterfrom
Conversation
joelanford
approved these changes
Apr 13, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM. Can you add an entry to the CHANGELOG under bugfixes?
Something like:
- Fixed issue in helm-operator where empty resource in release manifest caused failures while setting up watches for dependent resources. ([#2831](https://github.com/operator-framework/operator-sdk/pull/2831))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description : Controller fails on empty manifest files from a Helm Chart.
Closes: #2622