Skip to content

[WIP] generate: bundle and packagemanifests subcommand reference PR#2956

Closed
estroz wants to merge 3 commits intooperator-framework:masterfrom
estroz:feature/new-generate-cmds
Closed

[WIP] generate: bundle and packagemanifests subcommand reference PR#2956
estroz wants to merge 3 commits intooperator-framework:masterfrom
estroz:feature/new-generate-cmds

Conversation

@estroz
Copy link
Copy Markdown
Member

@estroz estroz commented May 1, 2020

NOTE: this is a reference PR

Description of the change:

  • generate bundle: generate bundle manifests and metadata for current and new project layouts.
  • generate packagemanifests: generate packages in the package manifests format for current and new project layouts. For current project layouts, this command should be used instead of generate csv.

Motivation for the change: we need commands that differentiate bundle and package manifests formats for both current and new project layouts.

TODO:

  • rewrite tests (currently broken) in BDD style using gomega/ginkgo.
  • better testdata for current and new project layouts.
  • break this PR up into several PR's, one for each command and each project layout type.

/kind feature

Eric Stroczynski added 2 commits May 1, 2020 14:40
…hich

will generate a bundle or package manifests format for a project, respectively.
These commands have pre- and post-kubebuilder integration modes.

cmd/operator-sdk/generate: bundle and packagemanifests commands;
CustomResourceDefinition updating behvior lives here

internal/generate/clusterserviceversion: modular ClusterServiceVersion
generator

internal/generate/packagemanifest: modular PackageManifest generator
@estroz estroz added the kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form label May 1, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 1, 2020
@estroz estroz changed the title [WIP] generate: add bundle and packagemanifests subcommands [WIP] generate: bundle and packagemanifests subcommand reference PR May 1, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@estroz: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Copy Markdown
Member Author

estroz commented Jun 15, 2020

Closing since all commands have open PR's or are in master.

@estroz estroz closed this Jun 15, 2020
@estroz estroz deleted the feature/new-generate-cmds branch June 15, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants