internal/generate: refactoring for new generate commands#3018
Merged
estroz merged 1 commit intooperator-framework:masterfrom May 13, 2020
Merged
internal/generate: refactoring for new generate commands#3018estroz merged 1 commit intooperator-framework:masterfrom
generate commands#3018estroz merged 1 commit intooperator-framework:masterfrom
Conversation
hasbro17
approved these changes
May 13, 2020
Contributor
hasbro17
left a comment
hasbro17
left a comment
There was a problem hiding this comment.
LGTM
I like the new CSV base getter. A lot easier to read than what we had before.
code. For now this just holds the base CSV generator and interactive prompt code, moved from olm-catalog internal/generate/olm-catalog: update CSV generator to use base getter internal/generate/testdata: update CSVs with new UI metadata defaults internal/util/k8sutil: NewYAMLScanner now takes an io.Reader rather than []byte directly
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
io.Readerrather than[]bytedirectlyMotivation for the change: #2860 is a fairly big PR containing some changes that made sense to break into their own PR. Additionally the new base CSV getter works well with the current CSV generator, so that has been refactored here as well.
/cc @hasbro17 @varshaprasad96 @joelanford