Skip to content

generate bundle: enable interactive mode, set metadata default#3087

Merged
estroz merged 1 commit intooperator-framework:masterfrom
estroz:feature/generate-bundle-interactive
May 22, 2020
Merged

generate bundle: enable interactive mode, set metadata default#3087
estroz merged 1 commit intooperator-framework:masterfrom
estroz:feature/generate-bundle-interactive

Conversation

@estroz
Copy link
Copy Markdown
Member

@estroz estroz commented May 22, 2020

Description of the change:

  • cmd/operator-sdk/generate/bundle: set default and allow interactive prompts
  • internal/generate/clusterserviceversion: change Options to accept projutil.InteractiveLevel arguments

Motivation for the change: --interactive was not added in #3065

This command is still "hidden" so I don't think a changelog fragment is needed.

/cc @hasbro17 @camilamacedo86 @jmrodri

Comment thread internal/generate/clusterserviceversion/clusterserviceversion.go Outdated
correct default in case no base bundle exists and --output-dir is set.

cmd/operator-sdk/generate/bundle: set default and allow interactive prompts

internal/generate/clusterserviceversion: change Options to accept
projutil.InteractiveLevel arguments
@estroz estroz force-pushed the feature/generate-bundle-interactive branch from a5118b2 to 5b9423c Compare May 22, 2020 18:32
Copy link
Copy Markdown
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 76f9431 into operator-framework:master May 22, 2020
@estroz estroz deleted the feature/generate-bundle-interactive branch May 22, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants