generate: add packagemanifests subcommand for legacy project layouts#3149
Merged
estroz merged 1 commit intooperator-framework:masterfrom Jun 18, 2020
Merged
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/generate-packagemanifests-legacy
branch
5 times, most recently
from
dc21927 to
69b666b
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
hasbro17
approved these changes
Jun 17, 2020
Contributor
hasbro17
left a comment
hasbro17
left a comment
There was a problem hiding this comment.
A couple nits but LGTM.
estroz
force-pushed
the
feature/generate-packagemanifests-legacy
branch
from
69b666b to
04eacd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
generate packagemanifestssubcommand for legacy project layouts. Similar implementation to the command in #3096 but no--kustomizeor--manifestsflags since only manifests are generated.Motivation for the change: See #3096.
/kind feature