Skip to content

Add and align reference docs for new KB docs#3209

Merged
hasbro17 merged 1 commit intooperator-framework:masterfrom
hasbro17:update-reference-docs-for-new-CLI
Jun 10, 2020
Merged

Add and align reference docs for new KB docs#3209
hasbro17 merged 1 commit intooperator-framework:masterfrom
hasbro17:update-reference-docs-for-new-CLI

Conversation

@hasbro17
Copy link
Copy Markdown
Contributor

The docs for the new CLI and workflow at website/content/en/docs/kubebuilder/ are missing the following docs:

  • references/event-filtering.md: This has been updated to reflect the new controller scaffold code.
  • references/markers.md: Copied as is from website/content/en/docs/golang/references because this would get lost when we remove the legacy docs from the master.

These will be moved along with the rest of the new Go docs from website/content/en/docs/kubebuilder/ to website/content/en/docs/golang/ in #3190

@hasbro17 hasbro17 added the kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form label Jun 10, 2020
Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@hasbro17 hasbro17 merged commit 56de473 into operator-framework:master Jun 10, 2020
@hasbro17 hasbro17 deleted the update-reference-docs-for-new-CLI branch June 10, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants