cli (new): add run packagemanifests#3253
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/run-packagemanifests
branch
from
2c6f22b to
a9c34f8
Compare
|
This command will incidentally read |
estroz
force-pushed
the
feature/run-packagemanifests
branch
6 times, most recently
from
c731f6a to
581ad00
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/run-packagemanifests
branch
3 times, most recently
from
21d4aa1 to
f2d0b07
Compare
…uts. This command must be used on operator projects with a package manifests format available. test/e2e-new: test `run packagemanifests` test/utils: add utils to install/uninstall OLM
estroz
force-pushed
the
feature/run-packagemanifests
branch
from
f2d0b07 to
68d194f
Compare
| Use: "packagemanifests", | ||
| Short: "Run an Operator organized in the package manifests format with OLM", | ||
| Short: "Deploy an Operator in the package manifests format with OLM", | ||
| Long: `'run packagemanifests' deploys an Operator's package manifests with OLM. The command's argument |
There was a problem hiding this comment.
if we have a choice between run packagemanifests and run olm, I'd vote for the latter one.
There was a problem hiding this comment.
@tengqm the reason we're thinking of using packagemanifests is to distinguish it from an upcoming run bundle subcommand. The idea is that we want to support various OLM packaging formats for the run subcommand, and if we tried to encapsulate all of that under a single run olm command, the UX would get unwieldy since there are some differences in how they work.
There was a problem hiding this comment.
Thanks for the info, @joelanford. I am just not a big fan of long commands, :).
There was a problem hiding this comment.
@estroz Perhaps we could add a cobra alias for this (e.g. operator-sdk run pm)?
There was a problem hiding this comment.
SGTM, I'll make a follow-up.
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM after we decide whether or not to add an alias.
| olm.NewCmd(), | ||
| printdeps.NewCmd(), | ||
| run.NewCmd(), | ||
| run.NewCmdLegacy(), |
There was a problem hiding this comment.
helm/Ansible still requiring run operator-sdk run --local with the new layout.
5 participants
Description of the change:
run packagemanifeststo new CLI, and set defaults for new project layoutsrun packagemanifestsMotivation for the change:
run packagemanifestsshould be available for new operator project layouts. This command must be used on operator projects with a package manifests format available./kind feature