refactor scorecard to be more testable#3287
Merged
jmccormick2001 merged 1 commit intooperator-framework:masterfrom Jun 30, 2020
Merged
refactor scorecard to be more testable#3287jmccormick2001 merged 1 commit intooperator-framework:masterfrom
jmccormick2001 merged 1 commit intooperator-framework:masterfrom
Conversation
Member
jberkhahn
force-pushed
the
refactor_scorecard
branch
4 times, most recently
from
e1873ef to
83b5e43
Compare
jberkhahn
force-pushed
the
refactor_scorecard
branch
from
83b5e43 to
5759765
Compare
jmccormick2001
approved these changes
Jun 26, 2020
varshaprasad96
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This refactors the alpha scorecard cmd to be more easily testable by making a command struct to contain the various fields, and moving the arg validation into a validate method, and the execution into a run method.
Motivation for the change:
As per #3246 I'm going through the commands that will survive the KB integration and adding unit tests for the cmd layer. It is difficult to write unit tests for commands with global vars and where the execution of the command is declared in-line in the cobra command declaration.