[run bundle]: Create bundle registry server by rashmigottipati · Pull Request #3337 · operator-framework/operator-sdk

rashmigottipati · 2020-07-02T17:11:50Z

Description of the change:

https://issues.redhat.com/browse/OSDK-1304

In this PR,

Create a kubernetes clientset and using the client, create a registry pod using a registryImage and set the container command (entrypoint) to:
{{/bin/bash -c ‘ \ /bin/mkdir -p /database && \ /bin/opm registry add -d /database/index.db -b {.BundleImage} && \ /bin/opm registry serve -d /database/index.db’}}
Before creation, verify if the registry pod already exists and return the existing pod if found
After creation of the pod, verify that it was successfully created by polling and verifying that pod status is running
Added functionality for capturing pod logs
Manual testing is done, unit testing is in progress

Note: Once the CLI code is ready, building the config and creating the client will be setup once in the CLI side, and passed along to this function.

Motivation for the change:

Initial step in order to create the registry server that serves an index image, useful for implementing run bundle and run bundle-upgrade commands
Enhancement proposal: https://github.com/operator-framework/enhancements/blob/master/enhancements/run-bundle.md

camilamacedo86

Assuming that it should not be called in any sdk command yet and that has a consensus to do ginkgo/gomega in a follow-up

It shows /lgtm /approve for me.

estroz

One nit then

/lgtm

jmrodri · 2020-07-14T23:23:44Z

/lgtm

- Validate RegistryPod struct fields and set defaults - Verify pod creation using polling and ensuring pod status is Running - Add logic to check if pod already exists and return existing pod - Add *corev1.Pod as an unexported field to RegistryPod struct - Make kubernetes client exported on RegistryPod so the caller can set it - Add templating for container command - Add logic to wrap pod logs inside error in case of failures - Use k8sutil's TrimDNS1123Label func to construct pod name - Add unit tests in ginkgo/gomega

jmrodri · 2020-07-14T23:33:30Z

/lgtm
/approve

Joe's comments were addressed by Rashmi.

rashmigottipati added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2020

rashmigottipati self-assigned this Jul 2, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2020

openshift-ci-robot requested review from hasbro17 and shawn-hurley July 2, 2020 17:11

rashmigottipati added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2020

rashmigottipati requested a review from jmrodri July 2, 2020 17:31

estroz suggested changes Jul 2, 2020

View reviewed changes

joelanford requested changes Jul 2, 2020

View reviewed changes

camilamacedo86 reviewed Jul 8, 2020

View reviewed changes

Comment thread internal/olm/operator/internal/registry_pod_test.go Outdated

camilamacedo86 reviewed Jul 8, 2020

View reviewed changes

Comment thread internal/olm/operator/internal/registry_pod_test.go Outdated

camilamacedo86 reviewed Jul 8, 2020

View reviewed changes