refactor cmd/cleanup/packagemanifests to be more testable#3375
Merged
camilamacedo86 merged 1 commit intooperator-framework:masterfrom Jul 15, 2020
Merged
refactor cmd/cleanup/packagemanifests to be more testable#3375camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
Conversation
camilamacedo86
approved these changes
Jul 11, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
/approve
@estroz any objection here?
Member
|
@jberkhahn can you rebase this PR. |
Contributor
Author
|
@jmrodri done |
Contributor
Author
|
hmm, the PR isn't picking up the updated branch for some reason... |
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
Well, this is so much worse |
jberkhahn
force-pushed
the
refactor_cleanup
branch
2 times, most recently
from
68c5938 to
66f5948
Compare
Contributor
|
Hi @jberkhahn, GH issues : https://www.githubstatus.com/ |
jberkhahn
force-pushed
the
refactor_cleanup
branch
from
1892359 to
810e238
Compare
Contributor
Author
|
this seems have to worked itself out by now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Refactor cmd/cleanup/packagemanifests to be more testable. This includes breaking up the functionality into validate and run method that can be individually tested.
Motivation for the change:
Ongoing work for #3246