Expose Kubernetes rest config#338
Merged
hasbro17 merged 1 commit intooperator-framework:masterfrom Jul 10, 2018
Merged
Conversation
|
This would be very useful for initializing other clients. At the moment I have recreate the code that is already in the SDK to get a new instance of the config to pass to my other clients |
Contributor
|
@nicolaferraro Yes I think exposing the config should be alright since there's a legitimate use case. |
hasbro17
reviewed
Jul 10, 2018
|
|
||
| // GetKubeConfig returns the kubernetes rest configuration | ||
| func GetKubeConfig() *rest.Config { | ||
| return kubeConfig |
Contributor
There was a problem hiding this comment.
@nicolaferraro After #340 you might want to rebase and change this to:
func GetKubeConfig() *rest.Config {
once.Do(newSingletonFactory)
return singletonFactory.kubeConfig
}ca2e3e4 to
395da06
Compare
Contributor
Author
|
Thanks @hasbro17, I think it should be ok now. |
m1kola
pushed a commit
to m1kola/operator-sdk
that referenced
this pull request
Jun 7, 2024
…istency-openshift-4.15-openshift-enterprise-helm-operator OCPBUGS-19197: Updating openshift-enterprise-helm-operator images to be consistent with ART
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to expose the rest configuration in order to be able to create custom clients e.g. a generic (non resource-scoped) dynamic client or a specific Openshift client in order to access some sub-resources (in my case, processing Openshift templates).
Can it be exposed?