Skip to content

*: remove test subcommand, pkg/test, and internal e2e tests for legacy projects#3409

Merged
estroz merged 1 commit intooperator-framework:masterfrom
estroz:refactor/remove-test-framework
Jul 13, 2020
Merged

*: remove test subcommand, pkg/test, and internal e2e tests for legacy projects#3409
estroz merged 1 commit intooperator-framework:masterfrom
estroz:refactor/remove-test-framework

Conversation

@estroz
Copy link
Copy Markdown
Member

@estroz estroz commented Jul 13, 2020

Description of the change: remove references to pkg/test, test local, and any tests that were solely based on test local.

Motivation for the change: This PR removes pkg/test, the test local subcommand, and internal SDK e2e tests from the test/test-framework sample project, as part of a larger effort to rely on unit tests, envtest, and happy path e2e testing.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz estroz added this to the v1.0.0 milestone Jul 13, 2020
Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
internal SDK e2e tests from the test/test-framework sample project,
as part of a larger effort to rely on envtest.

*: remove references to pkg/test, `test local`, and any tests
that were solely based on `test local`.
@estroz estroz force-pushed the refactor/remove-test-framework branch from 5b6ff37 to 0fcc138 Compare July 13, 2020 21:18
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@estroz estroz merged commit f075c55 into operator-framework:master Jul 13, 2020
@estroz estroz deleted the refactor/remove-test-framework branch July 13, 2020 22:35
@joelanford joelanford mentioned this pull request Jul 14, 2020
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants