Skip to content

cmd/ansible-operator,cmd/helm-operator: embed code in main.go#3415

Merged
joelanford merged 1 commit intooperator-framework:masterfrom
joelanford:ansible-helm-main
Jul 15, 2020
Merged

cmd/ansible-operator,cmd/helm-operator: embed code in main.go#3415
joelanford merged 1 commit intooperator-framework:masterfrom
joelanford:ansible-helm-main

Conversation

@joelanford
Copy link
Copy Markdown
Member

Description of the change:

  • Remove ansible.Run() and helm.Run() functions and move code to refactored ansible and helm main.go files
  • Remove shared WatchFlags and duplicate those flags in both the ansible and helm operator flag structs.

Motivation for the change:

  • Ansible and Helm operator code should be more self-contained in preparation for 1.0 release.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@jmrodri
Copy link
Copy Markdown
Member

jmrodri commented Jul 15, 2020

At first I didn't like this idea, I prefer a small main.go with another layer to do most of the work, but this looks okay to me. This might impact @VenkatRamaraju PR #3374

Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@joelanford joelanford merged commit 0cc777e into operator-framework:master Jul 15, 2020
@joelanford joelanford deleted the ansible-helm-main branch July 15, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants