helm:replace test in shell for go#3423
Merged
camilamacedo86 merged 2 commits intooperator-framework:masterfrom Jul 22, 2020
camilamacedo86:helm-plugin-go-test
Merged
helm:replace test in shell for go#3423camilamacedo86 merged 2 commits intooperator-framework:masterfrom camilamacedo86:helm-plugin-go-test
camilamacedo86 merged 2 commits intooperator-framework:masterfrom
camilamacedo86:helm-plugin-go-test
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
added
language/helm
joelanford
requested changes
Jul 16, 2020
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
estroz
reviewed
Jul 20, 2020
joelanford
requested changes
Jul 21, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
IMO, we shouldn't deploy/undeploy the project multiple times for different tests, since that will cause the test to take longer with little benefit.
For the tests that require a running operator, I think there should be one test file where the root level BeforeEach/AfterEach do the make deploy/make undeploy steps. Then all the tests that need a running operator (CR reconciliation, metrics) happen in that context.
joelanford
reviewed
Jul 22, 2020
joelanford
reviewed
Jul 22, 2020
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
Hi @estroz, All your suggestions were addressed as well. I am moving forward here for we are able to do the next task that requires these changes (e.g OLM sub running for noGo ones and its tests). However, please feel free to check again and let us know if has some detail/change that you think that should be applied. We can do it in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation of the change:
Replace the tests made to check the helm implementation in a shell script for golang