Skip to content

Removing escape characters in the operator-sdk binary build#3425

Merged
jmrodri merged 1 commit intooperator-framework:masterfrom
VenkatRamaraju:makefile-support
Jul 15, 2020
Merged

Removing escape characters in the operator-sdk binary build#3425
jmrodri merged 1 commit intooperator-framework:masterfrom
VenkatRamaraju:makefile-support

Conversation

@VenkatRamaraju
Copy link
Copy Markdown
Contributor

@VenkatRamaraju VenkatRamaraju commented Jul 14, 2020

Description of the change:
Removed the escape characters ( \ ) from the operator-sdk binary build, and added an -E flag to the sed command.

Motivation for the change:
Allows better parsing of command, especially by OSX.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

estroz
estroz approved these changes Jul 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
camilamacedo86
camilamacedo86 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

jmrodri
jmrodri approved these changes Jul 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm works on my linux box

@jmrodri jmrodri merged commit d1e2183 into operator-framework:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmrodri jmrodri jmrodri approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

+1 more reviewer

@estroz estroz estroz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@camilamacedo86 camilamacedo86

@estroz estroz

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VenkatRamaraju @jmrodri @camilamacedo86 @estroz @openshift-ci-robot