scorecard: use TestList for output, exit 1 on test failure#3427
Merged
joelanford merged 2 commits intooperator-framework:masterfrom Jul 15, 2020
Merged
scorecard: use TestList for output, exit 1 on test failure#3427joelanford merged 2 commits intooperator-framework:masterfrom
joelanford merged 2 commits intooperator-framework:masterfrom
Conversation
800649e to
d8ab436
Compare
ab86207 to
1df24ed
Compare
Contributor
|
seems to work for the basic/olm case, the kuttl image needs the updates for that to work again, also the custom test image would need the same updates. |
jmccormick2001
approved these changes
Jul 15, 2020
Member
Author
|
Just tested kuttl, it also works, which is expected because this PR does not change anything about the pod log interface and result gathering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
v1alpha3.Teststatus, use a newv1alpha3.TestListto output a list ofv1alpha3.Testobjects, one for each test defined in the scorecard config file.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs