Skip to content

Trivial - use consts rather than literals for env vars#3430

Merged
joelanford merged 1 commit intooperator-framework:masterfrom
tengqm:use-consts-instead-of-literals
Jul 15, 2020
Merged

Trivial - use consts rather than literals for env vars#3430
joelanford merged 1 commit intooperator-framework:masterfrom
tengqm:use-consts-instead-of-literals

Conversation

@tengqm
Copy link
Copy Markdown
Contributor

@tengqm tengqm commented Jul 15, 2020

Description of the change:
Use defined consts rather than literals when referencing environment variables.

Motivation for the change:
Avoid hard-coded strings in source code.

Checklist
No user facing changes introduced.

Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@joelanford joelanford merged commit fe330c1 into operator-framework:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants