Skip to content

Bug fix: helm operator uninstall is not properly checking for existing release #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estroz merged 4 commits into from
Feb 1, 2021
Merged

Bug fix: helm operator uninstall is not properly checking for existing release #3431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98cdb6b
helm/fix: uninstall is not properly checking for existing release
mikeshng Jul 15, 2020
d059952
syntax change for history check
mikeshng Jul 15, 2020
157e877
added changelog fragment
mikeshng Nov 12, 2020
48b0823
remove history check for manager uninstall release because it's alrea…
mikeshng Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fragments/helm-uninstall-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
entries:
- description: Fixed a bug that caused the Helm operator to remove the finalizer without doing a helm uninstall.
kind: "bugfix"
breaking: false
12 changes: 0 additions & 12 deletions internal/helm/release/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,18 +351,6 @@ func createJSONMergePatch(existingJSON, expectedJSON []byte) ([]byte, error) {

// UninstallRelease performs a Helm release uninstall.
func (m manager) UninstallRelease(ctx context.Context, opts ...UninstallOption) (*rpb.Release, error) {
// Get history of this release
h, err := m.storageBackend.History(m.releaseName)
if err != nil {
return nil, fmt.Errorf("failed to get release history: %w", err)
}

// If there is no history, the release has already been uninstalled,
// so return ErrReleaseNotFound.
if len(h) == 0 {
return nil, driver.ErrReleaseNotFound
}

uninstall := action.NewUninstall(m.actionConfig)
for _, o := range opts {
if err := o(uninstall); err != nil {
Expand Down