website,example: remove legacy docs and fixup links#3432
website,example: remove legacy docs and fixup links#3432joelanford merged 2 commits intooperator-framework:masterfrom
Conversation
joelanford
added
the
kind/documentation
| [v0.1.0-migration-guide]: ../v0.1.0-migration-guide | ||
| [manifest-format]: https://github.com/operator-framework/operator-registry#manifest-format | ||
| [client-doc]: ../../golang/legacy/references/client | ||
| [client-doc]: https://v0-19-x.sdk.operatorframework.io/docs/golang/legacy/references/client/ |
There was a problem hiding this comment.
Good spot since it was removed from the master we need to point out to the latest release with them 👍
| 1. Create nginx CR and wait for it to be ready. | ||
| 1. Scale up the dependent deployment and verify the operator reconciles it back down. | ||
| 1. Scale up the CR and verify the dependent deployment scales up accordingly. | ||
| 1. Delete nginx CR and verify that finalizer (which writes a message in the operator logs) ran. |
There was a problem hiding this comment.
hi @joelanford,
It shows great. just 2 nits.
- Should we not keep the watches implementation?
- Would be great if we could check that go.tmp is outdated with the PR changes? WDYT about we track an issue to see if we are able to find out a way to do it?
Otherwise,
/lgtm
/approve
| }) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Hi @joelanford,
Should we not keep the watches implementation?
I think the watch feature is described where the example is used.
There was a problem hiding this comment.
I:
- renamed
example/kb-memcached-operatortoexample/memcached-operator - removed references to the old
example/memcached-operator - updated references from
example/kb-memcached-operatortoexample/memcached-operator
I didn't look at the contents of the files at all.
There was a problem hiding this comment.
So, wdyt abut add here the watches back?
| @@ -1,141 +1,98 @@ | |||
| package memcached | |||
| /* | |||
There was a problem hiding this comment.
This file was just renamed from example/kb-memcached-operator/memcached_controller.go.tmpl
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
I think there's a typo, if it is please fix. If not, I'll change to approved.
| [addcli]: /docs/cli/operator-sdk_add_api | ||
| <!-- TODO: update this link to the non-legacy doc once the ansible plugin is publicly available --> | ||
| [quickstart-bundle]: /docs/olm-integration/legacy/quickstart-bundle | ||
| [quickstart-bundle]:https://v0-19-x.sdk.operatorframework.io/docs/olm-integration/legacy/quickstart-bundle/ |
There was a problem hiding this comment.
I'm assuming this is fully qualified because legacy only lives in 0.19 now.
There was a problem hiding this comment.
Once the ansible operator is updated, we'll probably update this link again to point to the new KB-based bundle quickstart.
5 participants
Description of the change:
Remove legacy docs and fixup links
Motivation for the change:
1.0 prep
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs