Helm: add leader election flags, use lease-based election#3446
Merged
joelanford merged 7 commits intooperator-framework:masterfrom Jul 17, 2020
Merged
Helm: add leader election flags, use lease-based election#3446joelanford merged 7 commits intooperator-framework:masterfrom
joelanford merged 7 commits intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
joelanford
force-pushed
the
helm-leader-election
branch
2 times, most recently
from
a061a63 to
e81015c
Compare
|
|
||
| # give permissions to reach the metrics endpoint | ||
| kubectl create clusterrolebinding nginx-operator-system-metrics-reader --clusterrole=nginx-operator-metrics-reader --serviceaccount=nginx-operator-system:default | ||
| kubectl create clusterrolebinding nginx-operator-system-metrics-reader --clusterrole=nginx-operator-metrics-reader --serviceaccount=${operator_namespace}:default |
92 tasks
joelanford
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Co-authored-by: Camila Macedo <cmacedo@redhat.com>
joelanford
force-pushed
the
helm-leader-election
branch
from
3f4b855 to
775702f
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Helm operator: add leader election flags, use controller-runtime leader election
Motivation for the change:
In general, the controller-runtime leader election method (lease-based) is preferable for most use cases. In the future, if there is a use case to support leader-for-life, we can add another flag to let operator developers choose their leader election mechanism.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs