ansible/helm: Rename max-workers to max-concurrent-reconciles#3452
ansible/helm: Rename max-workers to max-concurrent-reconciles#3452varshaprasad96 merged 3 commits intooperator-framework:masterfrom
Conversation
| Add "--max-concurrent-reconciles" flag to helm binary. Rename "max-workers" to "max-concurrent-reconciles" | ||
| in ansible/helm implementations. |
There was a problem hiding this comment.
Rename "max-workers" to "max-concurrent-reconciles" in ansible/helm implementations.
Is this referring to renaming/replacing the flag? In which case this is not an addition.
The verb "Rename" would be better suited to the Changed section.
Or is this referring to renaming the ansible controller Options field from MaxWorkers to MaxConcurrentReconcilers? I don't think that's a user facing change, and so we don't need to mention that in the CHANGELOG.
Also can you add a one line explanation for what --max-concurrent-reconciles does, or link to existing docs if we have those.
There was a problem hiding this comment.
Add "--max-concurrent-reconciles" flag to helm binary - meant the adding of a new flag, so that later we could deprecate --max-workers.
For Rename "max-workers" to "max-concurrent-reconciles" in ansible/helm implementations., I meant renaming the ansible controller Options field from MaxWorkers to MaxConcurrentReconcilers. Ill remove the second part from changelog.
8e1e9f8 to
a9cae00
Compare
a9cae00 to
2198a3a
Compare
| @@ -144,13 +144,13 @@ func main() { | |||
| } | |||
There was a problem hiding this comment.
Missing update the helm doc: https://github.com/operator-framework/operator-sdk/blob/master/website/content/en/docs/building-operators/helm/reference/advanced_features.md#changing-the-concurrent-worker-count
Also, could you please replace its example for to use the new layout? We have no longer the exec-entrypoint.
to use it we need to update the config/manager/manager.yaml with or run $ helm-operator --max-concurrent-reconciles=3
spec:
containers:
- image: {{ .Image }}
args:
- "--enable-leader-election"
- "--max-concurrent-reconciles=3"
name: managerThere was a problem hiding this comment.
@varshaprasad96 @camilamacedo86
This section was pre-emptively updated and wordsmith-ed here:
It would be better to make that update in this PR, so feel free to steal that section.
There was a problem hiding this comment.
merged the helm doc to help its updated.
PS.: I update the doc and forgot :-) tks
There was a problem hiding this comment.
Made a small addition to the existing doc.
camilamacedo86
left a comment
There was a problem hiding this comment.
just a few nits;
- rebase with the master (get docs)
- update the helm doc with the change
- update the fragment
Otherwise, it shows great 👍
This commit: - Adds --max-concurrent-reconciles flag to helm binary - Rename MaxWorkers to MaxConcurrentReconciles in ansible/helm implementations.
2198a3a to
60c9ca2
Compare
1a474a9 to
8625124
Compare
Description of the change:
This commit:
implementations.
Fixes: #3360
Motivation for the change:
Modify operator flags in ansible/helm operators to match controller-runtime constructs.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs