Add unit tests for cmd/version#3454
Merged
camilamacedo86 merged 2 commits intooperator-framework:masterfrom Jul 17, 2020
Merged
Add unit tests for cmd/version#3454camilamacedo86 merged 2 commits intooperator-framework:masterfrom
camilamacedo86 merged 2 commits intooperator-framework:masterfrom
Conversation
estroz
reviewed
Jul 17, 2020
Contributor
Author
|
@estroz done |
jberkhahn
force-pushed
the
version_tests
branch
3 times, most recently
from
3cdff46 to
af27c1f
Compare
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add unit tests for cmd/version. Also includes a small refactor, putting the cmd logic into a run() method so it can be tested.
Motivation for the change:
Ongoing work as part of #3246