Ansible: add leader election flags, use lease-based election#3457
Merged
jmrodri merged 2 commits intooperator-framework:masterfrom Jul 22, 2020
Merged
Ansible: add leader election flags, use lease-based election#3457jmrodri merged 2 commits intooperator-framework:masterfrom
jmrodri merged 2 commits intooperator-framework:masterfrom
Conversation
jmrodri
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
92 tasks
camilamacedo86
approved these changes
Jul 18, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Juts missing a nit to pass in the CI
However, it shows great
/lgtm
jmrodri
force-pushed
the
ansible-leader-election
branch
from
d859ddc to
1ea183f
Compare
|
New changes are detected. LGTM label has been removed. |
jmrodri
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jmrodri
force-pushed
the
ansible-leader-election
branch
3 times, most recently
from
8697445 to
4fdaee9
Compare
joelanford
approved these changes
Jul 21, 2020
fabianvf
reviewed
Jul 21, 2020
jmrodri
force-pushed
the
ansible-leader-election
branch
from
4fdaee9 to
918ac16
Compare
openshift-ci-robot
added
the
needs-rebase
jmrodri
force-pushed
the
ansible-leader-election
branch
from
918ac16 to
ebfd62c
Compare
openshift-ci-robot
removed
the
needs-rebase
16 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Ansible operator: add leader election flags, use controller-runtime leader election
Motivation for the change:
In general, the controller-runtime leader election method (lease-based) is preferable for most use cases. In the future, if there is a use case to support leader-for-life, we can add another flag to let operator developers choose their leader election mechanism.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs