Update golang.org/x/text to v0.3.3#3458
Merged
jmrodri merged 1 commit intooperator-framework:masterfrom Jul 22, 2020
Merged
Conversation
92 tasks
camilamacedo86
requested changes
Jul 18, 2020
| replace ( | ||
| github.com/Azure/go-autorest => github.com/Azure/go-autorest v13.3.2+incompatible // Required by OLM | ||
| github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.10.0 | ||
| golang.org/x/text => golang.org/x/text v0.3.3 |
Contributor
There was a problem hiding this comment.
Suggested change
| golang.org/x/text => golang.org/x/text v0.3.3 | |
| golang.org/x/text => golang.org/x/text v0.3.3 // Required to fix CVE-2020-14040 |
Contributor
There was a problem hiding this comment.
Just a nit ^ for we know why we are adding it.
camilamacedo86
approved these changes
Jul 18, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
However, it just solves the CEV in the SDK project and not for the project which is built with, So, if the same needs be done for the end-user projects that we need update the go.mod that is generated by the tool.
2 tasks
|
New changes are detected. LGTM label has been removed. |
jmrodri
force-pushed
the
update-golang-text
branch
from
1309365 to
dec6810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Pull in CVE-2020-14040 fixed by golang.org/x/text v0.3.3.
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs