Switch ansible/helm to use operator-lib predicate.#3481
Merged
jmrodri merged 1 commit intooperator-framework:masterfrom Jul 22, 2020
Merged
Switch ansible/helm to use operator-lib predicate.#3481jmrodri merged 1 commit intooperator-framework:masterfrom
jmrodri merged 1 commit intooperator-framework:masterfrom
Conversation
jmrodri
requested review from
estroz,
fabianvf and
joelanford
and removed request for
fabianvf and
shawn-hurley
92 tasks
estroz
approved these changes
Jul 21, 2020
Member
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
I assume there are no docs changes required for this.
/lgtm
joelanford
approved these changes
Jul 21, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
/lgtm
Looks like a rebase is needed
jmrodri
force-pushed
the
ansible-use-predicate
branch
from
3a9b4dd to
e519077
Compare
|
New changes are detected. LGTM label has been removed. |
We are bringing in operator-lib and using its predicate code. Then removing its implementation from the SDK repo.
jmrodri
force-pushed
the
ansible-use-predicate
branch
from
e519077 to
bbb9c38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are bringing in operator-lib and using its predicate code. Then removing its implementation from the SDK repo.
Description of the change:
Remove the internal implementation of the dependent predicate. Switch ansible and helm operators to use operator-framework/operator-lib's version of predicate.
Motivation for the change:
Move things that are generally useful for operator developers to operator-lib.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs