Scorecard e2e Testing#3507
Merged
jmrodri merged 12 commits intooperator-framework:masterfrom Jul 31, 2020
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
estroz
reviewed
Jul 23, 2020
estroz
reviewed
Jul 23, 2020
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jmccormick2001
approved these changes
Jul 24, 2020
Contributor
jmccormick2001
left a comment
jmccormick2001
left a comment
There was a problem hiding this comment.
looks good once you apply Eric's suggestion and it passes CI.
92 tasks
added 3 commits
July 24, 2020 14:03
estroz
reviewed
Jul 29, 2020
Comment on lines
+235
to
+239
| resultTable["olm-status-descriptors"] = v1alpha3.FailState | ||
| resultTable["olm-crds-have-resources"] = v1alpha3.FailState | ||
| resultTable["olm-bundle-validation"] = v1alpha3.PassState | ||
| resultTable["olm-spec-descriptors"] = v1alpha3.FailState | ||
| resultTable["olm-crds-have-validation"] = v1alpha3.PassState |
estroz
reviewed
Jul 29, 2020
| resultTable["olm-spec-descriptors"] = v1alpha3.FailState | ||
| resultTable["olm-crds-have-validation"] = v1alpha3.PassState | ||
|
|
||
| for a := 0; a < len(scorecardOutput.Items); a++ { |
Member
There was a problem hiding this comment.
Use test names to index into the resultTable map to make sure each test is run.
estroz
reviewed
Jul 29, 2020
| runOLMScorecardCmd := exec.Command(tc.BinaryName, "scorecard", "bundle", | ||
| "--selector=suite=olm", | ||
| "--output=json", | ||
| "--skip-cleanup=true", |
Member
There was a problem hiding this comment.
Any reason we're skipping cleanup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic and olm scorecard tests to e2e test suite.