Skip to content

cleanup: remove the funcs from k8sutil which are no longer used#3513

Merged
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:cleanup-funcs
Jul 24, 2020
Merged

cleanup: remove the funcs from k8sutil which are no longer used#3513
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:cleanup-funcs

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Jul 24, 2020

Description of the change:
After we remove the metrics this funcs are no longer used.
See that the fragment was not added because it has one for the users when the pkg was moved to internal.

Motivation for the change:

Closes: #3354

@camilamacedo86 camilamacedo86 added this to the v1.0.0 milestone Jul 24, 2020
@camilamacedo86 camilamacedo86 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 24, 2020
Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@camilamacedo86 camilamacedo86 merged commit 0e966e0 into operator-framework:master Jul 24, 2020
@camilamacedo86 camilamacedo86 deleted the cleanup-funcs branch July 24, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the code that generate the metrics for the new layout projects

3 participants