docs: fix broken links (CI)#3514
docs: fix broken links (CI)#3514joelanford merged 3 commits intooperator-framework:masterfrom camilamacedo86:remove-leader
Conversation
| During the lifecycle of an operator it's possible that there may be more than 1 instance running at any given time e.g when rolling out an upgrade for the operator. | ||
| In such a scenario it is necessary to avoid contention between multiple operator instances via leader election so that only one leader instance handles the reconciliation while the other instances are inactive but ready to take over when the leader steps down. | ||
|
|
||
| There are two different leader election implementations to choose from, each with its own tradeoff. |
There was a problem hiding this comment.
just removed the part of the sdk impl and all the rest of the texts were kept in the same way.
| this impl probably will came from operator-lib | ||
| however, we also need to check if we would not like to just let them use | ||
| https://github.com/kubernetes/kubernetes/pull/92717/files | ||
| [godoc-conditions]: https://godoc.org/github.com/operator-framework/operator-sdk/pkg/status#Conditions |
There was a problem hiding this comment.
this one is falling now. I am not sure if we will still providing or not the helper in via operator-lib so just comment and raised : #3515
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
I don't see any reason to remove the docs about leader for life. We just need to update the link to point to operator-lib
camilamacedo86
changed the title
| <!-- todo(camilamacedo) | ||
| the following link was comment for do no broke the CI | ||
| this impl probably will came from operator-lib | ||
| however, we also need to check if we would not like to just let them use | ||
| https://github.com/kubernetes/kubernetes/pull/92717/files |
There was a problem hiding this comment.
pkg/status was also moved to operator-lib. Let's just update that link as well.
And I don't think this is the appropriate place for a comment about the choice of implementations to use.
I think a better choice would be to open an issue in operator-lib asking whether it makes sense to deprecate status and point users to k8s.io/apimachinery's implementation.
3 participants
Description of the change:
docs: fix broken links (CI)
Motivation for the change:
fix CI and 1.0.0