Skip to content

replace instrumented handler with the one from operator-lib#3523

Merged
jmrodri merged 1 commit intooperator-framework:masterfrom
jmrodri:use-operator-lib-metrics
Jul 24, 2020
Merged

replace instrumented handler with the one from operator-lib#3523
jmrodri merged 1 commit intooperator-framework:masterfrom
jmrodri:use-operator-lib-metrics

Conversation

@jmrodri
Copy link
Copy Markdown
Member

@jmrodri jmrodri commented Jul 24, 2020

Description of the change:
Replace the instrumented handler with the one from operator-lib

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Comment thread pkg/ansible/controller/controller.go Outdated
Comment thread pkg/helm/controller/controller.go Outdated
Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri force-pushed the use-operator-lib-metrics branch from 53240c4 to aaf8bff Compare July 24, 2020 15:56
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@jmrodri jmrodri force-pushed the use-operator-lib-metrics branch from aaf8bff to 7ddaccd Compare July 24, 2020 17:49
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2020
@jmrodri jmrodri force-pushed the use-operator-lib-metrics branch from 7ddaccd to e98aba1 Compare July 24, 2020 18:09
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2020
@jmrodri jmrodri merged commit 69e3bfb into operator-framework:master Jul 24, 2020
@jmrodri jmrodri deleted the use-operator-lib-metrics branch August 17, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants