*: consistently use *.sdk.operatorframework.io wherever we use domains#3527
Merged
joelanford merged 1 commit intooperator-framework:masterfrom Jul 24, 2020
Merged
Conversation
Member
Author
|
I think I found all of them. If anyone knows of others, let me know! |
jmccormick2001
approved these changes
Jul 24, 2020
estroz
reviewed
Jul 24, 2020
estroz
reviewed
Jul 24, 2020
| $ mkdir nginx-operator | ||
| $ cd nginx-operator | ||
| $ operator-sdk init --plugins=helm.operator-sdk.io/v1 --domain=com --group=example --version=v1alpha1 --kind=Nginx | ||
| $ operator-sdk init --plugins=helm.sdk.operatorframework.io/v1 --domain=com --group=example --version=v1alpha1 --kind=Nginx |
Member
There was a problem hiding this comment.
Ideally we would direct users to use short names to get the latest non-default plugin:
Suggested change
| $ operator-sdk init --plugins=helm.sdk.operatorframework.io/v1 --domain=com --group=example --version=v1alpha1 --kind=Nginx | |
| $ operator-sdk init --plugins=helm --domain=com --group=example --version=v1alpha1 --kind=Nginx |
Member
Author
There was a problem hiding this comment.
I'll fix this in a follow-up.
92 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Use a consistent domain suffix for all SDK features (plugin names, annotations, etc.)
Motivation for the change:
Consistency and to align with a domain we actually own.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs