generate: remove --operator-name#3530
Merged
estroz merged 1 commit intooperator-framework:masterfrom Jul 29, 2020
Merged
Conversation
openshift-ci-robot
requested review from
camilamacedo86,
hasbro17 and
joelanford
estroz
commented
Jul 24, 2020
estroz
force-pushed
the
chore/use-project-name
branch
from
095cef2 to
f4bc418
Compare
estroz
force-pushed
the
chore/use-project-name
branch
from
f4bc418 to
4875e9b
Compare
joelanford
approved these changes
Jul 25, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
One (repeated) question.
Otherwise
/lgtm
openshift-ci-robot
added
lgtm
camilamacedo86
previously requested changes
Jul 27, 2020
Contributor
There was a problem hiding this comment.
IMO it is blocked by #3341.
Note that in #3341 we are centralizing the code to getOperatorName where has the validations suggested by @joelanford in the review made here. And then, we can:
- Merge #3341.
- Rebase it with master
- This pr will only change do the changes to replace the
--operator-namefromgeneratesubcommands in favor of usingproject-name - Also, then the changes performed here will be tested and we will be able to ensure that nothing breaks the OLM features for Go a NoGo operators as well. (before the #3341 we cannot test it via CI)
PS.: Note that the goal of #3341 is to fixes OLM subcommands for NoGo operators and add the tests to ensure that all will work well as expected.
92 tasks
estroz
changed the title
projectName over --operator-name, and remove flag--operator-name
estroz
force-pushed
the
chore/use-project-name
branch
from
4875e9b to
2faf035
Compare
openshift-ci-robot
removed
lgtm
estroz
force-pushed
the
chore/use-project-name
branch
3 times, most recently
from
35077ce to
bf0d53d
Compare
… be used instead
estroz
force-pushed
the
chore/use-project-name
branch
from
bf0d53d to
1ae7c2c
Compare
jmrodri
approved these changes
Jul 29, 2020
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
Minor nit if you have to fix other things. If not ignore. And a question to make sure we meant to remove the lower casing.
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| Remove `--operator-name` from `generate` subcommands in favor of using `project-name` |
Member
There was a problem hiding this comment.
Nit, not a PR blocker: I ended up having to update these to be past tense Removed because the changelog read weird with just Remove. For the migration guide Remove makes sense since it's an instruction.
| // makePkgManFileName will return the file name of a PackageManifest. | ||
| func makePkgManFileName(operatorName string) string { | ||
| return strings.ToLower(operatorName) + packageManifestFileExt | ||
| return operatorName + packageManifestFileExt |
Member
There was a problem hiding this comment.
Do we no longer need to lowercase this?
Member
Author
There was a problem hiding this comment.
We should assume operatorName is lowercased at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change: remove
--operator-nameflagMotivation for the change:
projectNameis now universal for plugins, so should be used instead of a flag value./cc @joelanford @camilamacedo86 @hasbro17
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs