Move pkg/helm to internal/helm#3537
Merged
jmrodri merged 2 commits intooperator-framework:masterfrom Jul 27, 2020
Merged
Conversation
hasbro17
requested review from
camilamacedo86,
estroz,
joelanford and
varshaprasad96
joelanford
approved these changes
Jul 25, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
Nit: I would prefer to keep the helm/internal/types structure, even within the existing root internal directory because it prevents those types from being imported outside the helm package tree.
Otherwise
/lgtm
joelanford
force-pushed
the
mv-pkg-helm-internal
branch
from
9f74c4c to
d124a98
Compare
Member
|
/lgtm |
92 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Move
pkg/helmtointernal/helm.Motivation for the change:
Remove public APIs in prep for
v1.0.0