doc: migration guide for Ansible and quickstart fixes#3571
Merged
jmrodri merged 4 commits intooperator-framework:masterfrom Aug 5, 2020
camilamacedo86:migration-ansible
Merged
doc: migration guide for Ansible and quickstart fixes#3571jmrodri merged 4 commits intooperator-framework:masterfrom camilamacedo86:migration-ansible
jmrodri merged 4 commits intooperator-framework:masterfrom
camilamacedo86:migration-ansible
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
asmacdo
reviewed
Jul 27, 2020
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
Author
|
Hi @joelanford @fabianvf @asmacdo, I think it is good to be merged to allow we have the docs and work easier with that but we will still need to do a follow up to improve the molecule section and after the migration. Could we work in this way? |
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
wkulhanek
reviewed
Jul 29, 2020
camilamacedo86
commented
Jul 30, 2020
8 tasks
asmacdo
reviewed
Jul 30, 2020
asmacdo
approved these changes
Jul 30, 2020
Member
asmacdo
left a comment
asmacdo
left a comment
There was a problem hiding this comment.
Some nits, no need for re-review
camilamacedo86
commented
Aug 5, 2020
camilamacedo86
commented
Aug 5, 2020
camilamacedo86
commented
Aug 5, 2020
camilamacedo86
commented
Aug 5, 2020
camilamacedo86
commented
Aug 5, 2020
camilamacedo86
commented
Aug 5, 2020
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
camilamacedo86
commented
Aug 5, 2020
camilamacedo86
commented
Aug 5, 2020
fabianvf
reviewed
Aug 5, 2020
Member
fabianvf
left a comment
fabianvf
left a comment
There was a problem hiding this comment.
Couple small issues, mostly looks good though
|
|
||
| And now: | ||
|
|
||
| - Use the var `${MOLECULE_PROJECT_DIRECTORY}` instead of `${MOLECULE_EPHEMERAL_DIRECTORY}` |
Member
There was a problem hiding this comment.
I'm not sure what these are referring to, I don't think they should change their usage of these variables
Contributor
Author
There was a problem hiding this comment.
I will remove this since we have a following up for the molecule.
| And now: | ||
|
|
||
| - Use the var `${MOLECULE_PROJECT_DIRECTORY}` instead of `${MOLECULE_EPHEMERAL_DIRECTORY}` | ||
| - Use the var `${KUBECONFIG:-"~/.kube/config"}` instead of `${MOLECULE_EPHEMERAL_DIRECTORY}/kubeconfig` to get the kubeconfig |
Member
There was a problem hiding this comment.
This is only true for the default scenario (which runs against an existing cluster), the kind scenario still uses the ephemeral kubeconfig
Contributor
Author
There was a problem hiding this comment.
I will remove this since we have a following up for the molecule.
We can re-check it in a follow-up.
92 tasks
jmrodri
requested changes
Aug 5, 2020
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
molecule is spelled wrong. And another nit.
| * RBAC manifests in `deploy` are now in `config/rbac/` | ||
|
|
||
| - `build/Dockerfile` is moved to `Dockerfile` in the project root directory | ||
| - The `molecue/` directory is now more aligned to Ansible and the new Layout |
|
|
||
| ## How to migrate | ||
|
|
||
| The easy migration path is to create a new project from the scratch and let the tool scaffold the new layout. Then, add your customizations and implementations. See below for an example. |
jmrodri
changed the title
jmrodri
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Partial closes: #3542 #3590
#3327
Follow-up of this one will be : operator-framework/ansible-operator-plugins#26 (to update the molecule docs)
PS.: PR to migrate the sample: operator-framework/operator-sdk-samples#138