cmd/helm|ansible-operator: add cobra subcommands#3596
Merged
jmrodri merged 6 commits intooperator-framework:masterfrom Jul 30, 2020
Merged
cmd/helm|ansible-operator: add cobra subcommands#3596jmrodri merged 6 commits intooperator-framework:masterfrom
jmrodri merged 6 commits intooperator-framework:masterfrom
Conversation
joelanford
force-pushed
the
ansible-helm-cobra
branch
from
b876f62 to
e67b93b
Compare
joelanford
force-pushed
the
ansible-helm-cobra
branch
from
e67b93b to
1f76115
Compare
92 tasks
camilamacedo86
approved these changes
Jul 29, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
it is passing in the Helm tests which is testing the make run 👍
Also, the code shows great.
joelanford
force-pushed
the
ansible-helm-cobra
branch
from
602507e to
3744571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
For both Helm and Ansible operators:
runsubcommandversionsubcommandrunsubcommand duringmake runMotivation for the change:
Make the ansible and helm operator binaries more flexible for future updates in 1.0
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs