<run|cleanup> packagemanifests: remove --include-paths, change --operator-version to --version#3599
Merged
estroz merged 1 commit intooperator-framework:masterfrom Jul 29, 2020
Conversation
openshift-ci-robot
requested review from
jmrodri,
joelanford and
rashmigottipati
…ved, and `--operator-version` has been changed to `--version`
estroz
force-pushed
the
chore/change-run-flags
branch
from
a466a2a to
905a829
Compare
camilamacedo86
approved these changes
Jul 29, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
when pass in the Ci
Member
rashmigottipati
left a comment
rashmigottipati
left a comment
There was a problem hiding this comment.
Why are we removing the checks hasSubscription and hasCatalogSource?
Member
Author
There is no way for a user to pass a Subscription or CatalogSource to the |
92 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: streamline flags
/cc @joelanford @rashmigottipati @jmrodri
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs