<run|cleanup> packagemanifests: remove --olm-namespace, change --operator-namespace to --namespace#3601
Merged
estroz merged 1 commit intooperator-framework:masterfrom Jul 29, 2020
Conversation
92 tasks
rashmigottipati
approved these changes
Jul 29, 2020
Member
rashmigottipati
left a comment
There was a problem hiding this comment.
/lgtm
after fixing typo in log message and CI passes
60dd523 to
6265bd4
Compare
jmrodri
approved these changes
Jul 29, 2020
| @@ -0,0 +1,15 @@ | |||
| entries: | |||
| - description: Removed the `--olm-namespace` flag from `run packagemanifests`. | |||
Member
There was a problem hiding this comment.
+1 to using the past tense, Removed, it reads better when the changelog is generated.
| header: Remove `--olm-namespace` from `run packagemanifests` invocations | ||
| body: > | ||
| OLM namespace is no longer required by this command. | ||
| - description: Changed the `--operator-namespace` flag to `--namespace` in `run packagemanifests`. |
Member
|
@estroz test broke |
Member
|
One clarification: we probably need to change this from |
…ed since it is no longer used by the command, and `--operator-namespace` has been renamed to `--namespace`.
6265bd4 to
af455e1
Compare
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
<run|cleanup packagemanifestsflag--olm-namespacehas been removed since it is no longer used by the command, and--operator-namespacehas been renamed to--namespace. OLM-adjacent resources (ex. registry deployment) are now created in the provided namespace, and OLM installation is no longer checked./cc @joelanford @jmrodri @rashmigottipati
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs