internal/operator-sdk/run|cleanup: initial boilerplate#3636
Merged
joelanford merged 9 commits intooperator-framework:masterfrom Aug 13, 2020
Merged
internal/operator-sdk/run|cleanup: initial boilerplate#3636joelanford merged 9 commits intooperator-framework:masterfrom
joelanford merged 9 commits intooperator-framework:masterfrom
Conversation
joelanford
requested review from
bharathi-tenneti,
estroz,
jmrodri and
rashmigottipati
joelanford
force-pushed
the
boilerplate-run-bundle
branch
from
45d908f to
57a48cf
Compare
14 tasks
joelanford
force-pushed
the
boilerplate-run-bundle
branch
2 times, most recently
from
4203f4e to
55e9b0b
Compare
Member
Author
|
/hold We might want to put this on a feature branch at least until 1.0 is released. WDYT? |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
needs-rebase
joelanford
force-pushed
the
boilerplate-run-bundle
branch
from
bc2ed5f to
92b998d
Compare
openshift-ci-robot
removed
the
needs-rebase
joelanford
force-pushed
the
boilerplate-run-bundle
branch
2 times, most recently
from
1d600a2 to
d8d5990
Compare
estroz
reviewed
Aug 12, 2020
estroz
reviewed
Aug 12, 2020
estroz
reviewed
Aug 12, 2020
joelanford
force-pushed
the
boilerplate-run-bundle
branch
2 times, most recently
from
d8147cc to
f8972eb
Compare
… and cleanup commands
joelanford
force-pushed
the
boilerplate-run-bundle
branch
from
579aa0b to
b560e68
Compare
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
estroz
reviewed
Aug 13, 2020
| return fmt.Errorf("load bundle: %v", err) | ||
| } | ||
|
|
||
| i.OperatorInstaller.PackageName = labels["operators.operatorframework.io.bundle.package.v1"] |
Member
There was a problem hiding this comment.
Related: I have a PR open that makes getting bundle metadata very straightforward, which we should start using once merged (no changes required now)
Member
Author
There was a problem hiding this comment.
Sweet! Look forward to that.
estroz
reviewed
Aug 13, 2020
| cfg *operator.Configuration | ||
| } | ||
|
|
||
| func NewIndexImageCatalogCreator(cfg *operator.Configuration) *IndexImageCatalogCreator { |
Member
There was a problem hiding this comment.
Any reason IndexImageCatalogCreator is exported and this signature isn't
Suggested change
| func NewIndexImageCatalogCreator(cfg *operator.Configuration) *IndexImageCatalogCreator { | |
| func NewIndexImageCatalogCreator(cfg *operator.Configuration, indexImage string, injectBundles []string, injectBundleMode string) CatalogCreator { |
?
Member
Author
There was a problem hiding this comment.
I'll take a look at this for a follow-up.
Member
Author
There was a problem hiding this comment.
Actually, one reason is that we could make NewIndexImageCatalogCreator work with just an index image. In that case, it could skip the entire registry pod setup and just create the CatalogSource with the spec.index field set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds commented out
run bundlecommand with flag and bundle parsing boilerplate.Motivation for the change:
To initialize a new package to be use for the
run bundlecommand and enable progress on implementation to be made in parallel.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs