Fix undefined var in scaffolded molecule tests#3654
Merged
asmacdo merged 2 commits intooperator-framework:masterfrom Aug 5, 2020
Merged
Fix undefined var in scaffolded molecule tests#3654asmacdo merged 2 commits intooperator-framework:masterfrom
asmacdo merged 2 commits intooperator-framework:masterfrom
Conversation
92 tasks
estroz
reviewed
Aug 5, 2020
Member
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
Do the molecule e2e tests need to be updated as well?
| project_dir: ${MOLECULE_PROJECT_DIRECTORY} | ||
| operator_image: testing-operator | ||
| pull_policy: "Never" | ||
| operator_pull_policy: "Never" |
Contributor
There was a problem hiding this comment.
it will be reverted?
I think @fabianvf changed that. Maybe is valid just ping him if you did not yet. :-)
Also, was it released in the alpha ones? If we we need to do a fragment file.
Member
There was a problem hiding this comment.
It's a typo from me 😬, this is definitely a fix
fabianvf
approved these changes
Aug 5, 2020
Member
Author
|
@estroz I dont think the e2e tests need to change since they are passing. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.