Various molecule scaffolding tweaks#3661
Merged
joelanford merged 1 commit intooperator-framework:masterfrom Aug 6, 2020
Merged
Various molecule scaffolding tweaks#3661joelanford merged 1 commit intooperator-framework:masterfrom
joelanford merged 1 commit intooperator-framework:masterfrom
Conversation
92 tasks
asmacdo
commented
Aug 6, 2020
|
|
||
| patchesStrategicMerge: | ||
| - manager_image.yaml | ||
| - pull_policy/Never.yaml |
Member
Author
There was a problem hiding this comment.
This caused a conflict when running kustomize build for config/testing
asmacdo
commented
Aug 6, 2020
| namespace: '{{ "{{ namespace }}" }}' | ||
| loop: "{{ "{{ q('k8s', api_version='v1', kind='Pod', namespace=namespace) }}" }}" | ||
| container: manager | ||
| loop: "{{ "{{ q('k8s', api_version='v1', kind='Pod', namespace=namespace, label_selector=ctrl_label) }}" }}" |
Member
Author
There was a problem hiding this comment.
Accessing Pod logs was not working
asmacdo
commented
Aug 6, 2020
| command: kind delete cluster --name osdk-test --kubeconfig {{ "{{ kubeconfig }}" }} | ||
|
|
||
| - name: Unset pull policy | ||
| command: '{{ "{{ kustomize }}" }} edit remove patch pull_policy/{{ "{{ operator_pull_policy }}" }}.yaml' |
Member
Author
There was a problem hiding this comment.
Cleanup was incomplete, could cause future kustomize conflicts.
fabianvf
approved these changes
Aug 6, 2020
Member
fabianvf
left a comment
fabianvf
left a comment
There was a problem hiding this comment.
/lgtm all good catches, thanks for fixing all my broken code 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: scaffolded operators had some problems running molecule tests.