run packagemanifests: change default install mode to AllNamespaces#3663
Merged
joelanford merged 1 commit intooperator-framework:masterfrom Aug 7, 2020
Merged
Conversation
joelanford
force-pushed
the
run-pkgman-allnamespaces
branch
from
ff55509 to
056eaa7
Compare
|
New changes are detected. LGTM label has been removed. |
joelanford
force-pushed
the
run-pkgman-allnamespaces
branch
from
056eaa7 to
5abf473
Compare
estroz
reviewed
Aug 6, 2020
| trap_add 'rm -rf $TMPDIR' EXIT | ||
| pushd "$TMPDIR" | ||
|
|
||
| mkdir -p $tmp_sdk_root |
Member
There was a problem hiding this comment.
Suggested change
| mkdir -p $tmp_sdk_root | |
| prepare_staging_dir $tmp_sdk_root |
estroz
approved these changes
Aug 6, 2020
Member
|
The integration tests are failing because the service accounts in the scaffolded CSV are wrong (unrelated to how the SDK actually scaffolds them). See #3668. |
joelanford
force-pushed
the
run-pkgman-allnamespaces
branch
from
560c81b to
bf28cf1
Compare
Member
Author
|
Rebased to get the fixes from #3668. Bumped the timeout to three minutes because past tests seem to be timing out. Tests are passing locally for me without the timeout change so hopefully its just that Travis needs more time now that |
joelanford
force-pushed
the
run-pkgman-allnamespaces
branch
2 times, most recently
from
5c31c4c to
21b391c
Compare
joelanford
force-pushed
the
run-pkgman-allnamespaces
branch
from
6ae811a to
eb7e5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
The default install mode for the
run packagemanifestscommand changed fromOwnNamespacetoAllNamespacesMotivation for the change:
In 1.0, operators are scaffolded to have cluster-scoped permissions and watch all namespaces, so it makes sense to align
run packagemanifestswith this default.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs