[run bundle] Use controller runtime client to create registry pod#3665
Merged
rashmigottipati merged 1 commit intooperator-framework:masterfrom Aug 11, 2020
Merged
Conversation
estroz
reviewed
Aug 6, 2020
estroz
reviewed
Aug 6, 2020
estroz
reviewed
Aug 6, 2020
rashmigottipati
force-pushed
the
registry-pod-client
branch
from
9ee8103 to
5140f51
Compare
estroz
reviewed
Aug 6, 2020
estroz
reviewed
Aug 6, 2020
rashmigottipati
force-pushed
the
registry-pod-client
branch
from
18ff1a6 to
e19d812
Compare
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
just a few nits for me. Otherwise, the code changes show ok but need the look from who attend the design meetings as well.
rashmigottipati
requested review from
bharathi-tenneti,
jmrodri and
joelanford
and removed request for
shawn-hurley
camilamacedo86
approved these changes
Aug 11, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
It shows ok for me 👍
/lgtm
however, please before merge gets +1 approval for who has been working on the same context and has been attending the meetings to discuss it.
rashmigottipati
force-pushed
the
registry-pod-client
branch
from
00fa03a to
0a484a5
Compare
rashmigottipati
force-pushed
the
registry-pod-client
branch
from
0a484a5 to
5a19391
Compare
estroz
reviewed
Aug 11, 2020
rashmigottipati
force-pushed
the
registry-pod-client
branch
from
5a19391 to
2314d73
Compare
|
New changes are detected. LGTM label has been removed. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: