Skip to content

feat: ansible e2e tests#3734

Merged
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:OSDK-1378
Aug 19, 2020
Merged

feat: ansible e2e tests#3734
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:OSDK-1378

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Aug 13, 2020

Description of the change:

  • Port the ansible-e2e test to Go
  • Add new tests to ensure that ansible projects have been covered

Note that:

  • the mock Memcached example still the same but is generated (so we have no longer the need to keep static mock files to replace the content)
  • its is adding tests to ensure OLM features and run local
  • It ensures the metrics
  • now we are creating the Memcached in an ns that is not the same as the operator to ensure that the cluster scope is working as should be.

Motivation for the change:

  • Keep all tests following the same standard and increase the maintenance ability
  • Ensure that the makefile targets are working since we are calling them
  • Ensure that we are testing the changes performed since no longer static data is used.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@camilamacedo86 camilamacedo86 requested review from asmacdo, fabianvf and theishshah and removed request for estroz and joelanford August 13, 2020 16:31
Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Seems weird to effectively write a script in go but I understand the goal. So +1.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@jberkhahn
Copy link
Copy Markdown
Contributor

iuno, I'd rather read the output of a go program blowing up than have to debug a 100+ line bash script blowing up

/lgtm

@camilamacedo86 camilamacedo86 merged commit 5cf9e6c into operator-framework:master Aug 19, 2020
@camilamacedo86 camilamacedo86 deleted the OSDK-1378 branch August 19, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants