Skip to content

run packagemanifests: registry server should use world-writable directory to write files#3867

Merged
joelanford merged 2 commits intooperator-framework:masterfrom
joelanford:run-pkgmnfs-writable-dir
Sep 11, 2020
Merged

run packagemanifests: registry server should use world-writable directory to write files#3867
joelanford merged 2 commits intooperator-framework:masterfrom
joelanford:run-pkgmnfs-writable-dir

Conversation

@joelanford
Copy link
Copy Markdown
Member

@joelanford joelanford commented Sep 9, 2020

Description of the change:
Write the bundle.db and termination.log file to /tmp when running the registry server for the run packagemanifests command.

Motivation for the change:
Resolves the issue raised here.

Fixes #3863

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@joelanford
Copy link
Copy Markdown
Member Author

@Doout can you try this branch out to see if it resolves this issue you brought up here?

@joelanford joelanford force-pushed the run-pkgmnfs-writable-dir branch from 1edcaa7 to 7aa8178 Compare September 9, 2020 21:23
Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@Doout
Copy link
Copy Markdown

Doout commented Sep 10, 2020

@joelanford I comment back on the issues, but still hit the permission denied with this PR.

@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@joelanford
Copy link
Copy Markdown
Member Author

@Doout @jmccormick2001 I updated this PR to set the registry pod working directory to /tmp, spun up a 4.5 cluster, and confirmed that the registry pod started successfully with this latest change.

@jmccormick2001
Copy link
Copy Markdown
Contributor

one thing I noticed is that when the pod, memcached-operator-registry-server-675559c6d5-6fwm5, is started, it is using imagePullPolicy of Always...I wonder if this is intended?

@joelanford
Copy link
Copy Markdown
Member Author

@jmccormick2001 imagePullPolicy defaults to Always when the image tag is latest; otherwise it defaults to IfNotPresent.

There's probably a separate discussion to be had about whether we should keep using latest, but this is what we've been using for the run packagemanifests command for awhile so that behavior hasn't changed.

@joelanford joelanford merged commit 4fe0e73 into operator-framework:master Sep 11, 2020
@joelanford joelanford deleted the run-pkgmnfs-writable-dir branch September 11, 2020 12:46
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Sep 17, 2020
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Sep 17, 2020
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operator-sdk run packagemanifests does not work on Openshift

5 participants