Skip to content

run bundle: Enable run bundle#3877

Merged
jmrodri merged 2 commits intooperator-framework:masterfrom
jmrodri:enable-run-bundle
Oct 6, 2020
Merged

run bundle: Enable run bundle#3877
jmrodri merged 2 commits intooperator-framework:masterfrom
jmrodri:enable-run-bundle

Conversation

@jmrodri
Copy link
Copy Markdown
Member

@jmrodri jmrodri commented Sep 15, 2020

Description of the change:
Enable the run bundle command. Depends on PR #3861

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@jmrodri
Copy link
Copy Markdown
Member Author

jmrodri commented Sep 15, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2020
@jmrodri
Copy link
Copy Markdown
Member Author

jmrodri commented Sep 15, 2020

Once the other run bundle PRs merge, this one can get rebased.

@jmrodri jmrodri changed the title Enable run bundle run bundle: Enable run bundle Sep 18, 2020
Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise
/lgtm

Comment thread internal/cmd/operator-sdk/run/cmd.go Outdated
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@jmrodri
Copy link
Copy Markdown
Member Author

jmrodri commented Sep 30, 2020

Closing because this code was added to the e2e test PR #3831

@jmrodri jmrodri closed this Sep 30, 2020
@jmrodri jmrodri reopened this Oct 5, 2020
@jmrodri
Copy link
Copy Markdown
Member Author

jmrodri commented Oct 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@jmrodri jmrodri force-pushed the enable-run-bundle branch from 5ea0dd9 to a29d7cb Compare October 5, 2020 17:53
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
Copy link
Copy Markdown
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@jmrodri jmrodri force-pushed the enable-run-bundle branch from a29d7cb to 02a5090 Compare October 6, 2020 02:09
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@jmrodri jmrodri force-pushed the enable-run-bundle branch from 02a5090 to e4a447a Compare October 6, 2020 02:29
@jmrodri jmrodri merged commit e6d94aa into operator-framework:master Oct 6, 2020
@jmrodri jmrodri mentioned this pull request Oct 6, 2020
2 tasks
@jmrodri jmrodri deleted the enable-run-bundle branch January 30, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants