Skip to content

generator: pull dependency at last step of new#39

Merged
hongchaodeng merged 1 commit intooperator-framework:masterfrom
hongchaodeng:v
Feb 22, 2018
Merged

generator: pull dependency at last step of new#39
hongchaodeng merged 1 commit intooperator-framework:masterfrom
hongchaodeng:v

Conversation

@hongchaodeng
Copy link
Copy Markdown
Contributor

To simplify the workflow, we would also pull down the dependencies in new generator.

But there are two options to set up dep:

  1. Render Gopkg.toml beforehand, since we know all the dependencies and can better control versions.
    Then do dep ensure.
  2. Do dep init. This would rely on the tool to pick the versions and introduce unpredictability. It might be simpler and more generic if we don't know some dependencies beforehand.
    Then do dep ensure.

@fanminshi
Copy link
Copy Markdown
Contributor

lgtm.

@hongchaodeng
Copy link
Copy Markdown
Contributor Author

@fanminshi
I have updated the comments. After evaluation, we would go with option 1 initially. Do you think that would be good?

@fanminshi
Copy link
Copy Markdown
Contributor

@hongchaodeng option 1 seems good with me. I like the fact that we are in control of certain dependencies so that we can ensure that operator-sdk will work properly.

@hongchaodeng hongchaodeng merged commit 45ab875 into operator-framework:master Feb 22, 2018
@hongchaodeng hongchaodeng deleted the v branch February 22, 2018 18:35
@fanminshi fanminshi mentioned this pull request Feb 22, 2018
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants