generator: pull dependency at last step of new#39
Merged
hongchaodeng merged 1 commit intooperator-framework:masterfrom Feb 22, 2018
hongchaodeng:v
Merged
generator: pull dependency at last step of new#39hongchaodeng merged 1 commit intooperator-framework:masterfrom hongchaodeng:v
new#39hongchaodeng merged 1 commit intooperator-framework:masterfrom
hongchaodeng:v
Conversation
Contributor
|
lgtm. |
Contributor
Author
|
@fanminshi |
Contributor
|
@hongchaodeng option 1 seems good with me. I like the fact that we are in control of certain dependencies so that we can ensure that operator-sdk will work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify the workflow, we would also pull down the dependencies in
newgenerator.But there are two options to set up dep:
Gopkg.tomlbeforehand, since we know all the dependencies and can better control versions.Then do
dep ensure.dep init. This would rely on the tool to pick the versions and introduce unpredictability. It might be simpler and more generic if we don't know some dependencies beforehand.Then do
dep ensure.