[e2e-test] Added the ginkgo style checks for e2e tests#3914
Merged
joelanford merged 1 commit intooperator-framework:masterfrom Sep 19, 2020
Merged
[e2e-test] Added the ginkgo style checks for e2e tests#3914joelanford merged 1 commit intooperator-framework:masterfrom
joelanford merged 1 commit intooperator-framework:masterfrom
Conversation
camilamacedo86
approved these changes
Sep 18, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Really thank you for the contribution 🥇
It is great.
/lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Added the ginkgo style checks for error messages rather then generating the error messages using fmt.Errorf()
Fixes #3771
Motivation for the change:
The changes was suggested in #3499 (comment) to better improve the readability of e2e tests.